dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721141
########## File path: CONTRIBUTING.md ########## @@ -583,67 +611,84 @@ class LoginForm(Form): # pylint: enable=too-few-public-methods ``` -# Git hooks +# Pre-commit hooks -Another great way of automating linting and testing is to use - [Git Hooks](https://git-scm.com/book/uz/v2/Customizing-Git-Git-Hooks). For example you could create a -`pre-commit` file based on the Travis CI Pipeline so that before each commit a local pipeline will be -triggered and if this pipeline fails (returns an exit code other than `0`) the commit does not come through. -This "in theory" has the advantage that you can not commit any code that fails that again reduces the -errors in the Travis CI Pipelines. +Pre-commit hooks are fantastic way of speeding up your local development cycle - you can run exactly the same +static code checks as are run in TravisCI but only limit the checks to the files you are just committing. Review comment: code checks that are running in TravisCI while limiting the checks to the files you are committing.* ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
