dimberman commented on a change in pull request #5777: [AIRFLOW-5161] Static checks are run automatically in pre-commit hooks URL: https://github.com/apache/airflow/pull/5777#discussion_r312721073
########## File path: CONTRIBUTING.md ########## @@ -348,17 +365,20 @@ they should give the same results as the tests run in TravisCI without special e You can trigger the static checks from the host environment, without entering Docker container. You do that by running appropriate scripts (The same is done in TravisCI) -* [ci_docs.sh](scripts/ci/ci_docs.sh) - checks that documentation can be built without warnings. -* [ci_flake8.sh](scripts/ci/ci_flake8.sh) - runs flake8 source code style guide enforcement tool -* [ci_mypy.sh](scripts/ci/ci_mypy.sh) - runs mypy type annotation consistency check -* [ci_pylint.sh](scripts/ci/ci_pylint.sh) - runs pylint static code checker -* [ci_lint_dockerfile.sh](scripts/ci/ci_lint_dockerfile.sh) - runs lint checker for the Dockerfile -* [ci_check_license.sh](scripts/ci/ci_check_license.sh) - checks if all licences are present in the sources +* [scripts/ci/ci_check_license.sh](scripts/ci/ci_check_license.sh) - checks if all licences are present in the sources +* [scripts/ci/ci_docs.sh](scripts/ci/ci_docs.sh) - checks that documentation can be built without warnings. +* [scripts/ci/ci_flake8.sh](scripts/ci/ci_flake8.sh) - runs flake8 source code style guide enforcement tool +* [scripts/ci/ci_lint_dockerfile.sh](scripts/ci/ci_lint_dockerfile.sh) - runs lint checker for the Dockerfile +* [scripts/ci/ci_mypy.sh](scripts/ci/ci_mypy.sh) - runs mypy type annotation consistency check +* [scripts/ci/ci_pylint_main.sh](scripts/ci/ci_pylint_main.sh) - runs pylint static code checker for main files +* [scripts/ci/ci_pylint_tests.sh](scripts/ci/ci_pylint_tests.sh) - runs pylint static code checker for tests -Those scripts are optimised for time of rebuilds of docker image. The image will be automatically -rebuilt when needed (for example when dependencies change). +Those scripts are optimised for time of rebuilds of docker image. The scripts will fail Review comment: "Those scripts are optimised for time of rebuilds of docker image." Could you please explain this line? I'm not sure I understand it... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
