TJaniF commented on code in PR #34392:
URL: https://github.com/apache/airflow/pull/34392#discussion_r1341133846
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -381,6 +381,8 @@ def _evaluate_direct_relatives() -> Iterator[TIDepStatus]:
elif trigger_rule == TR.ALL_SKIPPED:
if success or failed:
new_state = TaskInstanceState.SKIPPED
+ elif upstream_done and upstream_failed:
+ new_state = TaskInstanceState.UPSTREAM_FAILED
Review Comment:
That is a good question I feel I am not qualified to answer 😅
I see the argument for both, fail and upstream fail causing the same
response (that is what I did at first)
and also for upstream fail to be different because who knows if it could
have been skipped like @hussein-awala suggested 🤔
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -381,6 +381,8 @@ def _evaluate_direct_relatives() -> Iterator[TIDepStatus]:
elif trigger_rule == TR.ALL_SKIPPED:
if success or failed:
new_state = TaskInstanceState.SKIPPED
+ elif upstream_done and upstream_failed:
+ new_state = TaskInstanceState.UPSTREAM_FAILED
Review Comment:
That is a good question I feel I am not qualified to answer 😅
I see the argument for both, fail and upstream fail causing the same
response (that is what I did at first)
and also for upstream fail to be different because who knows if it could
have been skipped like @hussein-awala suggested 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
