hussein-awala commented on code in PR #34392:
URL: https://github.com/apache/airflow/pull/34392#discussion_r1341155725
##########
airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -381,6 +381,8 @@ def _evaluate_direct_relatives() -> Iterator[TIDepStatus]:
elif trigger_rule == TR.ALL_SKIPPED:
if success or failed:
new_state = TaskInstanceState.SKIPPED
+ elif upstream_done and upstream_failed:
+ new_state = TaskInstanceState.UPSTREAM_FAILED
Review Comment:
> Why should upstream failed not be treated the exact same as failed?
For me, when an upstream TI ends with a success or failed state, we know
that our TI cannot be run our TI, so we can skip (or fast skip) it.
However, when there is no success/failed upstream and we have an upstream
with upstream_failed state, we cannot skip the TI because we don't know the
state of this upstream when we run it, so by switching to `upstream_failed` we
tell the user "Sorry we cannot determine the state of your TI".
But if you just consider `upstream_failed` equivalent to `failed` in this
situation, TBH I don't have a strong opinion on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
