hussein-awala commented on code in PR #34716:
URL: https://github.com/apache/airflow/pull/34716#discussion_r1342902526
##########
chart/values.yaml:
##########
@@ -220,6 +220,31 @@ ingress:
# the name of a pre-created Secret containing a TLS private key and
certificate
secretName: ""
+# Enable the creation of a Kubernetes HTTPRoute and HealthCheckPolicy
+httpRoute:
+ web:
+ # Enable web ingress resource
+ enabled: false
+ # Annotations for the web HTTPRoute
+ annotations: {}
+ # The hostnames or hosts configuration for the web HTTPRoute
+ hostnames: []
+ # The Gateway API configuration
+ gateway:
+ name: your-gateway
+ namespace: namespace-for-your-gateway
Review Comment:
You can keep them empty, and check in the template if they are provided, and
fail if they are not (at least name, and maybe use chart namespace as namespace
for gateway). Otherwise, users will try to use it with default values, and it
will fail.
##########
chart/values.yaml:
##########
@@ -220,6 +220,31 @@ ingress:
# the name of a pre-created Secret containing a TLS private key and
certificate
secretName: ""
+# Enable the creation of a Kubernetes HTTPRoute and HealthCheckPolicy
+httpRoute:
+ web:
+ # Enable web ingress resource
+ enabled: false
+ # Annotations for the web HTTPRoute
+ annotations: {}
+ # The hostnames or hosts configuration for the web HTTPRoute
+ hostnames: []
+ # The Gateway API configuration
+ gateway:
+ name: your-gateway
+ namespace: namespace-for-your-gateway
+ flower:
+ # Enable flower HTTPRoute resource
+ enabled: false
+ # Annotations for the flower HTTPRoute
+ annotations: {}
+ # The hostnames or hosts configuration for the flower HTTPRoute
+ hostnames: []
+ # The Gateway API configuration
+ gateway:
+ name: your-gateway
+ namespace: namespace-for-your-gateway
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]