Xiroo commented on code in PR #34715:
URL: https://github.com/apache/airflow/pull/34715#discussion_r1343843951


##########
airflow/sensors/external_task.py:
##########
@@ -341,6 +341,7 @@ def execute(self, context: Context) -> None:
                     states=self.allowed_states,
                     trigger_start_time=utcnow(),
                     poll_interval=self.poll_interval,
+                    timeout=self.timeout,

Review Comment:
   I think 60 seconds doesn't have any meaning because it is the number fixed 
at 60 seconds not user's choice. Most of the users don't think too much about 
it and use it because it is just a fixed value. Rather, it makes users wonder 
why the deferrable mode's timeout is 60 seconds and not be able to find the 
answer in the docs, so it makes users look at the code like I did.
   
   IMHO, 60 seconds is not a proper value for default value since sensor does 
not raise any kind of time error(in general case) when using the non-deferrable 
sensor with default value. It can be confusing for users when the numbers 
aren't consistent.
   
   I'm even curious why 60 was chosen at first.🤔



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to