utkarsharma2 commented on code in PR #34715:
URL: https://github.com/apache/airflow/pull/34715#discussion_r1352086054
##########
airflow/sensors/external_task.py:
##########
@@ -341,6 +341,7 @@ def execute(self, context: Context) -> None:
states=self.allowed_states,
trigger_start_time=utcnow(),
poll_interval=self.poll_interval,
+ timeout=self.timeout,
Review Comment:
@Xiroo I saw the other comments and as long as we add a new parameter to get
the value from the user and they are aware of this change it should be fine.
Also, like the @uranusjr said it should be optional and the default of this can
be 60sec as before.
##########
airflow/sensors/external_task.py:
##########
@@ -341,6 +341,7 @@ def execute(self, context: Context) -> None:
states=self.allowed_states,
trigger_start_time=utcnow(),
poll_interval=self.poll_interval,
+ timeout=self.timeout,
Review Comment:
@Xiroo I saw the other comments and as long as we add a new parameter to get
the value from the user and they are aware of this change it should be fine.
Also, like @uranusjr said it should be optional and the default of this can be
60sec as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
