Owen-CH-Leung commented on PR #34735: URL: https://github.com/apache/airflow/pull/34735#issuecomment-1753105429
@kimminw00 Thanks. I've examined the 6 k8s recommended labels in the prometheus chart and I find that there's a difference for the labels `app.kubernetes.io/name` and `app.kubernetes.io/part-of`. In prometheus chart, these 2 labels are set as default `Chart.Name`, and can be overriden by `nameOverride` in the `values.yaml` file. In airflow chart, this field also exists so I think we can implement the same logic as well. For the other 4 labels (`app.kubernetes.io/version`, `helm.sh/chart`, `app.kubernetes.io/managed-by` and `app.kubernetes.io/instance`), I think my current logic is the same as the prometheus chart. Feel free to let me know if I'm wrong or I miss anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
