potiuk commented on code in PR #35109: URL: https://github.com/apache/airflow/pull/35109#discussion_r1367933717
########## dev/breeze/src/airflow_breeze/global_constants.py: ########## @@ -28,8 +28,10 @@ from airflow_breeze.utils.host_info_utils import Architecture from airflow_breeze.utils.path_utils import AIRFLOW_SOURCES_ROOT, PROVIDER_DEPENDENCIES_JSON_FILE_PATH -RUNS_ON_PUBLIC_RUNNER = "ubuntu-22.04" -RUNS_ON_SELF_HOSTED_RUNNER = "self-hosted" +RUNS_ON_PUBLIC_RUNNER = '["ubuntu-22.04"]' +# we should get more sophisticated logic here in the future, but for now we just check if +# we use self airflow, vm-based, amd hosted runner as a default +RUNS_ON_SELF_HOSTED_RUNNER = '["self-hosted", "airflow-runner", "vm-runner", "X64"]' Review Comment: > I don't seed the labels attached to [the runners](https://github.com/apache/airflow/actions/runners?tab=self-hosted); we need to check before merging to avoid blocking the committers' PRs. Yeah. This one won't get green until that works, so no worries :) > I think this should passed as an array instead of a string; it will be serialized to JSON by GHA 🤔 It's complicated. We can only print strings as outputs and when needed they need to be converted to arrays with "toJSON" method - but its not obvious how so I am playing with it now to get the right combination :shrug: GA woes. ########## dev/breeze/src/airflow_breeze/global_constants.py: ########## @@ -28,8 +28,10 @@ from airflow_breeze.utils.host_info_utils import Architecture from airflow_breeze.utils.path_utils import AIRFLOW_SOURCES_ROOT, PROVIDER_DEPENDENCIES_JSON_FILE_PATH -RUNS_ON_PUBLIC_RUNNER = "ubuntu-22.04" -RUNS_ON_SELF_HOSTED_RUNNER = "self-hosted" +RUNS_ON_PUBLIC_RUNNER = '["ubuntu-22.04"]' +# we should get more sophisticated logic here in the future, but for now we just check if +# we use self airflow, vm-based, amd hosted runner as a default +RUNS_ON_SELF_HOSTED_RUNNER = '["self-hosted", "airflow-runner", "vm-runner", "X64"]' Review Comment: > I don't seed the labels attached to [the runners](https://github.com/apache/airflow/actions/runners?tab=self-hosted); we need to check before merging to avoid blocking the committers' PRs. Yeah. This one won't get green until that works, so no worries :) > I think this should passed as an array instead of a string; it will be serialized to JSON by GHA 🤔 It's complicated. We can only print strings as outputs and when needed they need to be converted to arrays with "toJSON" method - but its not obvious how so I am playing with it now to get the right combination :shrug: GA woes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
