potiuk commented on code in PR #35109: URL: https://github.com/apache/airflow/pull/35109#discussion_r1367935390
########## dev/breeze/src/airflow_breeze/global_constants.py: ########## @@ -28,8 +28,10 @@ from airflow_breeze.utils.host_info_utils import Architecture from airflow_breeze.utils.path_utils import AIRFLOW_SOURCES_ROOT, PROVIDER_DEPENDENCIES_JSON_FILE_PATH -RUNS_ON_PUBLIC_RUNNER = "ubuntu-22.04" -RUNS_ON_SELF_HOSTED_RUNNER = "self-hosted" +RUNS_ON_PUBLIC_RUNNER = '["ubuntu-22.04"]' +# we should get more sophisticated logic here in the future, but for now we just check if +# we use self airflow, vm-based, amd hosted runner as a default +RUNS_ON_SELF_HOSTED_RUNNER = '["self-hosted", "airflow-runner", "vm-runner", "X64"]' Review Comment: Unfortunately not.... Outputs are always Unicode strings - so converting them to JSON just causes subsequent encoding :shrug: ... We need to run `fromJSON` in all the places where the outputs are used as part of workflow definition ... I think I got it right now... But indeed our runners do not have the right labels defined and do not pick the jobs up: > Requested labels: self-hosted, airflow-runner, vm-runner, X64 Job defined at: apache/airflow/.github/workflows/ci.yml@refs/pull/35109/merge Waiting for a runner to pick up this job... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
