uranusjr commented on code in PR #35048:
URL: https://github.com/apache/airflow/pull/35048#discussion_r1368256292
##########
airflow/utils/log/secrets_masker.py:
##########
@@ -279,9 +279,9 @@ def _redact(self, item: Redactable, name: str | None,
depth: int, max_depth: int
# but it caused infinite recursion, so we need to cast it to str first.
except Exception as exc:
log.warning(
- "Unable to redact %r, please report this via
<https://github.com/apache/airflow/issues>. "
+ "Unable to redact %s, please report this via
<https://github.com/apache/airflow/issues>. "
"Error was: %s: %s",
- item,
+ repr(item),
Review Comment:
Pre-rendering a log message is against best practice since it would not work
well for external logging services such as Sentry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
