uranusjr commented on code in PR #35096:
URL: https://github.com/apache/airflow/pull/35096#discussion_r1368356030


##########
airflow/models/dagrun.py:
##########
@@ -228,7 +252,7 @@ def __init__(
         self.execution_date = execution_date
         self.start_date = start_date
         self.external_trigger = external_trigger
-        self.conf = conf or {}
+        self._conf = ConfDict(_conf)

Review Comment:
   ```suggestion
           self._conf = ConfDict(_conf or {})
   ```
   
   Is this not needed to keep the current behaviour? Otherwise None would no 
longer be an allowed value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to