uranusjr commented on code in PR #35096:
URL: https://github.com/apache/airflow/pull/35096#discussion_r1368358997
##########
airflow/models/dagrun.py:
##########
@@ -126,7 +150,7 @@ class DagRun(Base, LoggingMixin):
creating_job_id = Column(Integer)
external_trigger = Column(Boolean, default=True)
run_type = Column(String(50), nullable=False)
- conf = Column(PickleType)
+ _conf = Column(PickleType)
Review Comment:
This would require a database migration. I wonder if it would be better to
make this a custom SQLAlchemy column type so selecting `conf` automatically
converts to ConfDict without going through the additional `@property` layer.
That would avoid possible bugs if someone does something like
`session.scalar(select(DagRun.conf))` (this would not go through the
`@property` getter!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
