makrushin-evgenii commented on code in PR #35105:
URL: https://github.com/apache/airflow/pull/35105#discussion_r1368574855


##########
airflow/providers/ftp/hooks/ftp.py:
##########
@@ -213,9 +205,8 @@ def store_file(
             input_handle = open(local_full_path_or_buffer, "rb")
         else:
             input_handle = local_full_path_or_buffer
-        remote_path, remote_file_name = os.path.split(remote_full_path)
-        conn.cwd(remote_path)
-        conn.storbinary(f"STOR {remote_file_name}", input_handle, block_size)
+
+        conn.storbinary(f"STOR {remote_full_path}", input_handle, block_size)

Review Comment:
   I got `ftplib.error_perm: 550 Failed to open file` when surround path with 
quotes. But your proposal is understandable. Now there should be problems if 
there are spaces in the path



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to