makrushin-evgenii commented on code in PR #35105:
URL: https://github.com/apache/airflow/pull/35105#discussion_r1367952109
##########
airflow/providers/ftp/hooks/ftp.py:
##########
@@ -182,10 +185,12 @@ def write_to_file_with_progress(data):
callback = output_handle.write
remote_path, remote_file_name = os.path.split(remote_full_path)
+ current_path = conn.pwd()
conn.cwd(remote_path)
self.log.info("Retrieving file from FTP: %s", remote_full_path)
conn.retrbinary(f"RETR {remote_file_name}", callback, block_size)
Review Comment:
You're right. The old implementation confused me, I thought that this was
impossible - so I tried to get around it by calling the method again. Perhaps
there was a reason for this approach?
https://github.com/apache/airflow/pull/35105/commits/86f92cabba9156bbe1dbce1aa46bc33fce901e27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
