potiuk commented on PR #35192: URL: https://github.com/apache/airflow/pull/35192#issuecomment-1780574428
I do not think this is needed at alll 1) even if that script includes the common file - it does not seem to use any of it so at most i'd just **REMOVE** using the common script (and test it as well) 2) This "run_docs_build.sh" simply executes python command and hardly does anything else. I do not think we should rewrite it. We should only rewrite scripts that contain some complex-ish logic in it. Having a script that is just wrapping execution of python command to simplify setting environment variables etc. seems like a legitimate use of bash script IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
