bolkedebruin commented on code in PR #35273:
URL: https://github.com/apache/airflow/pull/35273#discussion_r1376711263
##########
airflow/providers/amazon/aws/fs/s3.py:
##########
@@ -85,7 +85,15 @@ def get_fs(conn_id: str | None) -> AbstractFileSystem:
if proxy_uri := s3_service_config.get(S3_PROXY_URI, None):
config_kwargs["proxies"] = {"http": proxy_uri, "https": proxy_uri}
- fs = S3FileSystem(session=session, config_kwargs=config_kwargs,
endpoint_url=endpoint_url)
+ anon = False
+ if (
+ aws.conn_config.aws_access_key_id is None
+ and aws.conn_config.aws_secret_access_key is None
+ and aws.conn_config.aws_session_token is None
+ ):
+ anon = True
Review Comment:
Here we are trying to to do this
```python
x = ObjectStoragePath("s3://xxxx")
```
There is no way to pass `config_kwargs` to this at the moment, and I don't
think that makes sense for this use case like I said.
However, note that passing `conn_id=None` here does use the default
credentials strategy of boto3, which might return *empty* credentials (i.e. it
*might* mean anonymous). I am only setting `anon=True` if no credentials are
returned. So I think we're good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
