potiuk commented on issue #35381: URL: https://github.com/apache/airflow/issues/35381#issuecomment-1792294117
> > We define three predefined templates for each case > > How do you suggest to use it? How can user point to a specific template? I thought about three cases we have - success/failure/retry and passing information to notifier which case we are currently "Serving. But IMHO - we do not need to discuss too much if wa agree on general direction. IMHO lots of details of those kind of changes os really up to the who who takes on the task of implementing it. Quite often i find out that idea should be just hashed out "good enough" to get everyone's "this is a good direction" and then hash out details in PR- especially when it comes to such a "Small" feature. I often feel that you need just a high level direction of such change before writing first PR Draft by somoeone who will actually take a leadership on implementing it and starts POC and PR. Discussion seeing the code and someone actually commited to do do and complete stuff are simply way more productive IMHO. In this case I think having a general agreement on: > Let's have an extension of SMTPNotifier that has predefined templates to handle the three different usages and allows to easily customize it in declarative way. would be where I would end up a discussion before seeing someone produce a firs draft proposal and ask for comments and feedback, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
