potiuk commented on PR #35337: URL: https://github.com/apache/airflow/pull/35337#issuecomment-1792833125
I d not know those parts that well, but in a first glance it seems a bit ... to simple. That's at least the impression I have that the way timetables are used and implemented, there is some inherent complexity in handling edge cases - aligning the dates, switching DSTs etc. etc. . At least this was the impression I had looking at past problems and issues. I tihnk @uranusjr knows those best and maybe he can comment on my worries at least. If anything - I think my impression is that this one would reqiuire quite a bit more tests and maybe not even unit tests but some integration tests that are covering actual scheduling scenarios. But again it coudl be just impression resulting from looking over the shoulders of those who implemented and reviewed timeteables previously, so I will leave the jugment of tha to them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
