potiuk commented on PR #35337: URL: https://github.com/apache/airflow/pull/35337#issuecomment-1792846827
> I found an error here in airflow webserver logs (not covered by tests): > > https://github.com/apache/airflow/blob/8c25304f047dd77dde6802155a894ce9a15481a8/airflow/api_connexion/schemas/common_schema.py#L130 > > > `Exception: Unknown object type: list` > How to properly fix that? No idea, but it calls for new API parameter - API needs to be stable and provide backwards compatibility to the clients that our users use, we cannot just CHANGE the API - the old API needs to stay as is and likely new parameters (I assume it is in returned value) should return more complex data structure). That's a "general" statement - not sure how it applies to this particular case, but one of the complexities of this task is to make sure the other parts of the system are just handling the new ways of specifying Cron expressions. I guess (I have not looked in detail) but UI is also somehow recognising Cron timetables a bit differently and handling them a bit differently than regular timetables (for performance and visualisation) - so my guess is what you see there is part of the "special treatment" of the cron-like timetables that needs to be also updated (this is what I also think is part of my perceived "it looks too simple to handle all edge cases" comment above. But again - that's my intelligent guess - I have not look at that code for quite a while and have not a lot of capacity to do so now, it's just my impression of the complexity of the task of adding multiple cron specifications (but again - I might be quite wrong here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
