kaxil commented on code in PR #35462: URL: https://github.com/apache/airflow/pull/35462#discussion_r1382636161
########## airflow/serialization/serializers/deltalake.py: ########## @@ -0,0 +1,79 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING + +from airflow.utils.module_loading import qualname + +serializers = ["deltalake.table.DeltaTable"] +deserializers = serializers +stringifiers = serializers + +if TYPE_CHECKING: + from airflow.serialization.serde import U + +__version__ = 1 + + +def serialize(o: object) -> tuple[U, str, int, bool]: + from deltalake.table import DeltaTable Review Comment: >If we do move some serializers to providers , which is probably the right thing to do, then it makes more sense improve this. Yeah we will need to handle that sooner. delta for example, is still on 0.x (https://pypi.org/project/deltalake/#history) so in theory can be broken if they follow SemVer >Docs yes, but I think having that with the rework into providers is more logical. Are you planning to do that soon before we release the next minor Airflow version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
