bolkedebruin commented on code in PR #35462: URL: https://github.com/apache/airflow/pull/35462#discussion_r1382637249
########## airflow/serialization/serializers/deltalake.py: ########## @@ -0,0 +1,79 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING + +from airflow.utils.module_loading import qualname + +serializers = ["deltalake.table.DeltaTable"] +deserializers = serializers +stringifiers = serializers + +if TYPE_CHECKING: + from airflow.serialization.serde import U + +__version__ = 1 + + +def serialize(o: object) -> tuple[U, str, int, bool]: + from deltalake.table import DeltaTable Review Comment: I agree, on the other hand we rely only very lightly on the API, just enough to be able to re-instantiate it. Not sure if I get it in for a next minor release. Provider re-work isn't much fun :-). And this serialization, while it works, is not the final work. I was thinking about doing something like `airflow.catalog`, but I am not sure about that yet. In addition I am thinking a about Arrow, maybe that should be our `default` format for this. Again, not sure and I need to play with it a bit more. Hence, for now, the lightweight part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
