uranusjr commented on code in PR #35465:
URL: https://github.com/apache/airflow/pull/35465#discussion_r1382728100
##########
.pre-commit-config.yaml:
##########
@@ -1000,7 +1000,7 @@ repos:
name: Run mypy for providers
language: python
entry: ./scripts/ci/pre_commit/pre_commit_mypy.py --namespace-packages
- files:
^airflow/providers/.*\.py$|^tests/providers/\*\.py$|^tests/system/providers/\*\.py$
+ files:
^airflow/providers/.*\.py$|^tests/providers/.*\.py$|^tests/system/providers/.*\.py$
Review Comment:
```suggestion
files:
^airflow/providers/.*\.py$|^tests/providers/.+\.py$|^tests/system/providers/.+\.py$
```
Doesn’t really matter in practice but I don’t think we want to allow a file
named exactly `.py`
##########
.pre-commit-config.yaml:
##########
@@ -1000,7 +1000,7 @@ repos:
name: Run mypy for providers
language: python
entry: ./scripts/ci/pre_commit/pre_commit_mypy.py --namespace-packages
- files:
^airflow/providers/.*\.py$|^tests/providers/\*\.py$|^tests/system/providers/\*\.py$
+ files:
^airflow/providers/.*\.py$|^tests/providers/.*\.py$|^tests/system/providers/.*\.py$
Review Comment:
```suggestion
files:
^airflow/providers/.*\.py$|^tests/providers/.+\.py$|^tests/system/providers/.+\.py$
```
Doesn’t really matter in practice but I don’t think we want to allow a file
named exactly `.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
