Lee-W commented on code in PR #35465:
URL: https://github.com/apache/airflow/pull/35465#discussion_r1382726086
##########
tests/system/providers/google/cloud/cloud_sql/example_cloud_sql_query_mysql.py:
##########
@@ -42,8 +42,10 @@
)
from airflow.utils.trigger_rule import TriggerRule
+# mypy: disable-error-code="call-overload"
+
if TYPE_CHECKING:
- from airflow.settings import Session
+ pass
Review Comment:
If there's nothing here, should we just remove it?
##########
tests/system/providers/google/cloud/dataplex/example_dataplex.py:
##########
@@ -41,7 +41,7 @@
from airflow.utils.trigger_rule import TriggerRule
ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
-PROJECT_ID = os.environ.get("SYSTEM_TESTS_GCP_PROJECT")
+PROJECT_ID = os.environ.get("SYSTEM_TESTS_GCP_PROJECT") or "project_id"
Review Comment:
```suggestion
PROJECT_ID = os.environ.get("SYSTEM_TESTS_GCP_PROJECT", "project_id")
```
should we make it this way for consistency?
##########
tests/system/providers/google/cloud/data_loss_prevention/example_dlp_info_types.py:
##########
@@ -64,12 +65,14 @@
OBJECT_GCS_OUTPUT_URI = OBJECT_GCS_URI + FILE_NAME
CUSTOM_INFO_TYPE_ID = "custom_info_type"
-CUSTOM_INFO_TYPES = {
- "large_custom_dictionary": {
- "output_path": {"path": OBJECT_GCS_OUTPUT_URI},
- "cloud_storage_file_set": {"url": OBJECT_GCS_URI + "*"},
+CUSTOM_INFO_TYPES = StoredInfoTypeConfig(
+ {
+ "large_custom_dictionary": {
+ "output_path": {"path": OBJECT_GCS_OUTPUT_URI},
+ "cloud_storage_file_set": {"url": OBJECT_GCS_URI + "*"},
Review Comment:
should we use f-string instead?
```suggestion
"cloud_storage_file_set": {"url": f"{OBJECT_GCS_URI}*"},
```
##########
tests/system/providers/google/cloud/cloud_sql/example_cloud_sql_query_postgres.py:
##########
@@ -43,7 +43,7 @@
from airflow.utils.trigger_rule import TriggerRule
if TYPE_CHECKING:
- from airflow.settings import Session
+ pass
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
