potiuk commented on code in PR #35465: URL: https://github.com/apache/airflow/pull/35465#discussion_r1382930335
########## tests/system/providers/google/cloud/automl/example_automl_translation.py: ########## @@ -24,7 +24,7 @@ from datetime import datetime from typing import cast -from google.cloud import storage +from google.cloud import storage # type: ignore[attr-defined] Review Comment: I tried to mov it to setup.cfg. it seems that storage is simply not yet mypy-ready: https://github.com/googleapis/python-storage/issues/393 However, I have a hard time finding an easy way to exclude it in config more selectively. I tried few ways and I seem I cannot do it other than (or I do not know a better way): I tried few approaches (ignore_missing_imports on google.cloud level, ignore_errors on google.cloud.storage level etc. etc. .. Seems that ignoring this one attr-defined is better as it is very selective (and also it is close to the source, which is kinda better than somewhat distant specification in config). I added a comment to https://github.com/googleapis/python-storage/issues/393 as an explanation and I think it should be "good-enough". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
