Taragolis commented on code in PR #35465: URL: https://github.com/apache/airflow/pull/35465#discussion_r1382928691
########## tests/system/providers/google/cloud/cloud_sql/example_cloud_sql_query_mysql.py: ########## @@ -42,8 +42,10 @@ ) from airflow.utils.trigger_rule import TriggerRule +# mypy: disable-error-code="call-overload" + if TYPE_CHECKING: - from airflow.settings import Session + pass Review Comment: I think we could change a bit our ruff rules configuration for allow `TCH005` and maybe `TCH004`: https://docs.astral.sh/ruff/rules/#flake8-type-checking-tch ```toml # pyproject.toml extend-select = [ ... "TCH", ] extend-ignore = [ ... "TCH003", ] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
