uranusjr commented on code in PR #34851:
URL: https://github.com/apache/airflow/pull/34851#discussion_r1384410794
##########
airflow/models/dag.py:
##########
@@ -224,8 +225,12 @@ def create_timetable(interval: ScheduleIntervalArg,
timezone: Timezone) -> Timet
if isinstance(interval, (timedelta, relativedelta)):
return DeltaDataIntervalTimetable(interval)
if isinstance(interval, str):
- return CronDataIntervalTimetable(interval, timezone)
- raise ValueError(f"{interval!r} is not a valid interval.")
+ create_cron_data_intervals = airflow_conf.get("scheduler",
"create_cron_data_intervals")
+ if create_cron_data_intervals:
Review Comment:
```suggestion
if airflow_conf.get("scheduler", "create_cron_data_intervals"):
```
##########
airflow/models/dag.py:
##########
@@ -224,8 +225,12 @@ def create_timetable(interval: ScheduleIntervalArg,
timezone: Timezone) -> Timet
if isinstance(interval, (timedelta, relativedelta)):
return DeltaDataIntervalTimetable(interval)
if isinstance(interval, str):
- return CronDataIntervalTimetable(interval, timezone)
- raise ValueError(f"{interval!r} is not a valid interval.")
+ create_cron_data_intervals = airflow_conf.get("scheduler",
"create_cron_data_intervals")
+ if create_cron_data_intervals:
Review Comment:
```suggestion
if airflow_conf.getboolean("scheduler",
"create_cron_data_intervals"):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
