dstandish commented on PR #35416: URL: https://github.com/apache/airflow/pull/35416#issuecomment-1798827388
@hussein-awala my cleanup in this PR actually does a little more that just remove the the passing around of the logs object. I also remove unused argument `termination_timeout` and unnecessary param `follow` (in the consume func). Since passing around the logs object presently has no effect, then it is still appropriate to remove IMHO. My vote would be to merge this now, and then later if someone wants to reintroduce something along the lines of https://github.com/apache/airflow/pull/34127, and with appropriate testing, they can do so after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
