dkim010 commented on PR #35416: URL: https://github.com/apache/airflow/pull/35416#issuecomment-1793624209
> Do you agree @hussein-awala and @dkim010? I think this PR is an appropriate cleanup. You are right. I agree with that #34412 made #34127 have any effect. > KPO logging is now extremely convoluted. One avenue for cleanup is getting rid of some irrelevant `follow=` logic, which I'll try to do. Some of that was relevant only when triggers could not log, so we added periodic resuming and log capturing, which is not a feature in this operator anymore. Would you explain why the `follow=` logic is irrelevant to KPO logging? And, I think the `test_fetch_container_logs_failures` test case (related to the `follow=` logic) should be passed. Is the test case passed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
