jedcunningham commented on code in PR #35505:
URL: https://github.com/apache/airflow/pull/35505#discussion_r1385837798
##########
airflow/www/templates/appbuilder/navbar.html:
##########
@@ -21,6 +21,13 @@
{% set languages = appbuilder.languages %}
<div class="navbar navbar-fixed-top" role="navigation"
style="background-color: {{ navbar_color }};">
+ {% if navbar_text_color %}
Review Comment:
We should move this into
[main.html](https://github.com/apache/airflow/blob/637ec90dfca86e57c8c0dbae64af1865db22eb9c/airflow/www/templates/airflow/main.html#L49)
instead.
##########
airflow/www/templates/appbuilder/navbar.html:
##########
@@ -21,6 +21,13 @@
{% set languages = appbuilder.languages %}
<div class="navbar navbar-fixed-top" role="navigation"
style="background-color: {{ navbar_color }};">
+ {% if navbar_text_color %}
+ <style>
+ .navbar .navbar-collapse .navbar-nav a {
Review Comment:
```suggestion
.navbar-nav > li > a {
```
This is probably a better selector to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
