vchiapaikeo commented on code in PR #35505:
URL: https://github.com/apache/airflow/pull/35505#discussion_r1387983798


##########
airflow/config_templates/config.yml:
##########
@@ -1614,6 +1614,13 @@ webserver:
       type: string
       example: ~
       default: "#fff"
+    navbar_text_color:
+      description: |
+        Define the color of text in the navigation bar
+      version_added: 2.8.0
+      type: string
+      example: ~
+      default: ""

Review Comment:
   Yea, that's a good point. The reason I added the condition is because it 
acts like an override. Unlike the navbar background-color which is inline 
styled, color is defined on 
https://github.com/apache/airflow/blob/main/airflow/www/static/css/main.css#L56,
 but we can't dynamically modify the css.
   
   That said, I can go either way here. Happy to do whatever the community 
prefers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to