pierrejeambrun commented on code in PR #35392:
URL: https://github.com/apache/airflow/pull/35392#discussion_r1387617196
##########
airflow/api_connexion/openapi/v1.yaml:
##########
@@ -3579,7 +3579,7 @@ components:
timezone:
$ref: '#/components/schemas/Timezone'
catchup:
- type: boolean
+ type: string
Review Comment:
I believe so, changing the type of one field would be breaking. (Either in
response or request).
Indeed True False need to still be accepted.
Also even if string “True” “False” are accepted, we just need to confirm in
the client what happens if we pass a Boolean object to a string field. Does it
get silently cast to string or does it crash I am not sure. That could break
there as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
