hussein-awala commented on PR #35392: URL: https://github.com/apache/airflow/pull/35392#issuecomment-1804814819
> Bas is not saying catchup false is not intuitive in general, he's talking about the specific behavior that a run is immediately created even when catchup is false. IMHO this has nothing to do with this PR, changing the behavior of False (disable) approach is completely unrelated to the new proposed option. > I think we are way too eager to make everything configurable and we need to be more opinionated sometimes, and just pick a behavior. More configuration means more complex code that is more bug prone and more difficult to change. Also more confusing for users, more surface area of features and settings to understand. I don't know if (1) you are comparing adding new options to an existing param and adding a new conf, or (2) you are talking in general about providing to our users a new option as a new feature. If it's (1), I don't know why you consider it more confusing to add new options to an existing param since the existing values will stay supported with the exact same behavior, and we will add a new option with clear documentation and explanation that compares the 3 options (I'm waiting for the end of the discussion to write it once). I started the PR with a new param, but I found that @Taragolis is right about simplifying it by changing the catchup type. An alternative solution could be adding a new param that can replace catchup in the future, similar to what we did in https://github.com/apache/airflow/pull/30718, which replaced `is_delete_operator_pod` with `on_finish_action `, but since the param name is not confusing as it was the case in the other PR, I don't think it's necessary here. If it's (2), I would ask for more clarification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
