uranusjr commented on PR #35612:
URL: https://github.com/apache/airflow/pull/35612#issuecomment-1811884082
I read the implementation and it seems the parsing logic in
`ObjectStoragePath` is a bit fragile if the user passes in some weird combo like
```python
P = ObjectStoragePath
P(P("s3://bucket/path"), P("azure://storage/path"))
```
In pathlib, passing in an absolute path would simply overwrite everything
passed in previous arguments and simply gives you back that absolute path, but
from I can tell the current implementation cannot do that, and returns a
somewhat nonsensical result. I’ll provide some improvements maybe after this is
merged or at least stablises.
Another no directly related point, I’m thinking we can probably merge
`conn_id` into the URI itself like this: `s3://conn_id@bucket/`. This seems
cleaner from the user’s standpoint. The conn_id value should still be parsed
out in the implementation, but I feel the user shouldn’t be required to pass it
in as a separate argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
