bolkedebruin commented on code in PR #35612:
URL: https://github.com/apache/airflow/pull/35612#discussion_r1393798347


##########
setup.cfg:
##########
@@ -163,6 +163,7 @@ install_requires =
     # See https://github.com/apache/airflow/pull/31693
     # We should also remove "licenses/LICENSE-unicodecsv.txt" file when we 
remove this dependency
     unicodecsv>=0.14.1
+    universal_pathlib>=0.1.4

Review Comment:
   The nature of `pathlib.Path` I think has prevented alternatives to come to 
the fore. It did prevent me from deriving from it. I think the risk is limited 
as `upath` implements the `pathlib.Path` API as a target and therefore will be 
bound to that.  We could argue we want to pin it specifically to this version 
to be more predictable. The downside of that is that `upath` might pin a 
particular dependency (e.g. `fsspec`) in the future (it doesn't now) to 
something we do not like.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to