eladkal commented on code in PR #35488:
URL: https://github.com/apache/airflow/pull/35488#discussion_r1397646758
##########
airflow/providers/amazon/provider.yaml:
##########
@@ -91,6 +91,7 @@ dependencies:
- redshift_connector>=2.0.888
- sqlalchemy_redshift>=0.8.6
- asgiref
+ - python3-saml
Review Comment:
Do we want it as dependency or in additional-extras ?
##########
airflow/providers/amazon/provider.yaml:
##########
@@ -895,6 +896,28 @@ config:
type: boolean
example: "True"
default: "True"
+ aws_auth_manager:
+ description: |
+ This section only applies if you are using the AwsAuthManager. In other
words, if you set
+ ``[core] auth_manager =
airflow.providers.amazon.aws.auth_manager.aws_auth_manager.AwsAuthManager`` in
+ Airflow's configuration.
+ options:
+ use_experimental:
+ description: |
+ AWS auth manager is not ready to be used. Turn on this flag to use
it anyway.
+ Do that at your own risk since the AWS auth manager is not in an
usable state.
+ version_added: 8.11.0
+ type: boolean
+ example: "True"
+ default: "False"
Review Comment:
mmm this feels a bit odd?
The feature itself may be marked as experimental.
I guess my issue is more with the name of the config. I suggest
`enable=True/False` rather than `use_experimental=True/False`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
