eladkal commented on code in PR #35488: URL: https://github.com/apache/airflow/pull/35488#discussion_r1397695145
########## airflow/providers/amazon/provider.yaml: ########## @@ -91,6 +91,7 @@ dependencies: - redshift_connector>=2.0.888 - sqlalchemy_redshift>=0.8.6 - asgiref + - python3-saml Review Comment: to my perspective dependency is something that is crucial to 85%+ of the providers uses. Without it the provider has no meaning (for example `boto3`) Extra is something that relatively small subset of users need thus must ask for it explicitly. The motivation for it is that we need to remember that users do custom stuff on top of Airflow. For example consider that I have some internal libraries that I install with Airflow (generate my own constraint file) the last thing I want is to handle conflicts with library that I don't even use just because it is installed by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
