uranusjr commented on code in PR #35747:
URL: https://github.com/apache/airflow/pull/35747#discussion_r1401481912
##########
airflow/io/path.py:
##########
@@ -40,21 +40,15 @@
PT = typing.TypeVar("PT", bound="ObjectStoragePath")
-default = "file"
-
class _AirflowCloudAccessor(_CloudAccessor):
__slots__ = ("_store",)
- def __init__(self, parsed_url: SplitResult | None, **kwargs: typing.Any)
-> None:
- store = kwargs.pop("store", None)
- conn_id = kwargs.pop("conn_id", None)
- if store:
- self._store = store
- elif parsed_url and parsed_url.scheme:
+ def __init__(self, parsed_url: SplitResult | None, conn_id: str, **kwargs:
typing.Any) -> None:
Review Comment:
Would `conn_id: str | None = None` make this more comfortable? The interface
difference is not a tachnically relevant issue IMO, but making the argument
optional is not a big deal to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
