uranusjr commented on code in PR #35747:
URL: https://github.com/apache/airflow/pull/35747#discussion_r1401483042
##########
airflow/io/path.py:
##########
@@ -89,15 +83,18 @@ class ObjectStoragePath(CloudPath):
"_hash",
)
- def __new__(cls: type[PT], *args: str | os.PathLike, **kwargs: typing.Any)
-> PT:
+ def __new__(
+ cls: type[PT],
+ *args: str | os.PathLike,
+ scheme: str | None = None,
Review Comment:
This does not. Since both the parent definition and this one take
`**kwargs`, adding a keyword-only argument does not change the caller interface
at all. The only difference is when `scheme` is not provided by the caller, an
explicit argument receives a default (None in this case) while the key would be
absent in `**kwargs`. But since the implementation here uses `pop()` anyway,
the end result is exactly equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
