hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1405478899
##########
airflow/www/static/js/dag/details/index.tsx:
##########
@@ -138,6 +146,7 @@ const Details = ({
const isGroupOrMappedTaskSummary = isGroup || isMappedTaskSummary;
const showLogs = !!(isTaskInstance && !isGroupOrMappedTaskSummary);
const showMappedTasks = !!(isTaskInstance && isMappedTaskSummary &&
!isGroup);
+ const showXcom = !!(isTaskInstance && !isGroupOrMappedTaskSummary);
Review Comment:
I have created `isIndividualTaskInstance` to house the logic and reuse this
in both `showLogs` and `showXcom`. Do you think I should remove `showLogs` and
`showXcom` altogether? To me, having these show... variables makes the code
easier to read without having to think "show log/xcom when it is an individual
task instance".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
