bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1406380334
##########
airflow/www/static/js/dag/details/index.tsx:
##########
@@ -136,7 +144,11 @@ const Details = ({
const isMappedTaskSummary = isMapped && mapIndex === undefined && taskId;
const isGroup = !!children;
const isGroupOrMappedTaskSummary = isGroup || isMappedTaskSummary;
- const showLogs = !!(isTaskInstance && !isGroupOrMappedTaskSummary);
+ const isIndividualTaskInstance = !!(
+ isTaskInstance && !isGroupOrMappedTaskSummary
+ );
+ const showLogs = isIndividualTaskInstance;
+ const showXcom = isIndividualTaskInstance;
Review Comment:
Although we should refactor the `isTaskInstance` var to reduce confusion.
Remove `isInvididualTaskInstance` and `isGroupOrMappedTaskSummary`.
Then just have `const isTaskInstance = taskId && runId && !isGroup &&
!isMappedSummary`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
