potiuk opened a new pull request, #35875:
URL: https://github.com/apache/airflow/pull/35875
Extracts comon initialization code for pre-commits that allows to use a
simpler way of running pre-commits with breeze ci image. Rather than running a
custom `docker` command, we are using the `breeze shell` command to run the
command inside the image. We are also fixing a problem where the ER diagram was
generated using random backend - we force it now to use Postgres as backend.
There are few small problems solved as part of it as well:
* We are also switching the console used to be the standard colored one so
that the output will use colors also in git hook and CI.
* When image needs update we are going to warn about it in the builds that
are "serial" (i.e. do not run in parallell) that the image should be upgraded.
We are not doing it for checks that use parallelism because it would pollute
the output too much (and those are usually not run with images anyway).
* There was an error where pre-commit run with breeze would also start
port-forwarding if database was started together with it, so pre-commit project
no longer adds port forwarding for backends.
* If there was a database stated as part of pre-commit project, it would
continue running after pre-commit completed, which is undesireable. The
pre-commit will now stop pre-commit project after completion.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
