pankajkoti commented on code in PR #35875:
URL: https://github.com/apache/airflow/pull/35875#discussion_r1405558458
##########
dev/breeze/src/airflow_breeze/utils/md5_build_check.py:
##########
@@ -126,34 +130,49 @@ def calculate_md5_checksum_for_files(
return modified_files, not_modified_files
-def md5sum_check_if_build_is_needed(md5sum_cache_dir: Path,
skip_provider_dependencies_check: bool) -> bool:
+def md5sum_check_if_build_is_needed(
+ build_ci_params: BuildCiParams, md5sum_cache_dir: Path,
skip_provider_dependencies_check: bool
+) -> bool:
"""
Checks if build is needed based on whether important files were modified.
+ :param build_ci_params: parameters for the build
:param md5sum_cache_dir: directory where cached md5 sums are stored
:param skip_provider_dependencies_check: whether to skip regeneration of
the provider dependencies
:return: True if build is needed.
"""
- build_needed = False
modified_files, not_modified_files = calculate_md5_checksum_for_files(
md5sum_cache_dir, update=False,
skip_provider_dependencies_check=skip_provider_dependencies_check
)
if modified_files:
+ if build_ci_params.skip_image_upgrade_check:
+ if build_ci_params.warn_image_upgrade_needed:
+ get_console().print(
+ "\n[warning]You are skipping the image upgrade check, but
the image needs and upgrade. "
Review Comment:
```suggestion
"\n[warning]You are skipping the image upgrade check,
but the image needs an upgrade. "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
