o-nikolas commented on code in PR #35928:
URL: https://github.com/apache/airflow/pull/35928#discussion_r1408263195
##########
airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -91,7 +91,13 @@ def is_authorized_configuration(
details: ConfigurationDetails | None = None,
user: BaseUser | None = None,
) -> bool:
- return self.is_logged_in()
+ config_section = details.section if details else None
Review Comment:
If the section is None then is this basically checking if the user is
authorized for all/any config?
##########
airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -142,7 +166,12 @@ def is_authorized_view(
access_view: AccessView,
user: BaseUser | None = None,
) -> bool:
- return self.is_logged_in()
+ return self.avp_facade.is_authorized(
+ method="GET",
+ entity_type=AvpEntities.VIEW,
+ user=user or self.get_user(),
+ entity_id=access_view.value,
Review Comment:
Why don't we have a check for this value and default to None like the others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
