vincbeck commented on code in PR #35928:
URL: https://github.com/apache/airflow/pull/35928#discussion_r1409492309
##########
airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -142,7 +166,12 @@ def is_authorized_view(
access_view: AccessView,
user: BaseUser | None = None,
) -> bool:
- return self.is_logged_in()
+ return self.avp_facade.is_authorized(
+ method="GET",
+ entity_type=AvpEntities.VIEW,
+ user=user or self.get_user(),
+ entity_id=access_view.value,
Review Comment:
The other are optional because when you do authorization request, you might
not need to specify a resource ID. Example: "Does the user have permission to
create a Variable". There is no resource ID here. Here this is not really a
resource ID but more a specific of which view the user is trying to access. We
must specify which view the user is trying to access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
