feluelle commented on a change in pull request #5786: [AIRFLOW-5170] Fix
encoding pragmas, consistent licences for python files and related pylint fixes
URL: https://github.com/apache/airflow/pull/5786#discussion_r314884652
##########
File path: .pre-commit-config.yaml
##########
@@ -39,6 +48,21 @@ repos:
- license-templates/LICENSE.txt
files: >
\.properties$|\.cfg$|\.conf$|\.ini$|\.ldif$|\.readthedocs$|\.service$|^Dockerfile.*$
+ - id: insert-license
+ name: Add licence for all JS files
+ files: \.js$
+ exclude: ^\.github/.*$|^airflow/_vendor/.*$
+ args:
+ - --comment-style
+ - "/**| *| */"
+ - --license-filepath
+ - license-templates/LICENSE.txt
+ - repo: https://github.com/pre-commit/pre-commit-hooks
+ rev: v2.3.0
+ hooks:
+ - id: debug-statements
+ - id: fix-encoding-pragma
+ exclude: ^\.github/.*$"|^airflow/_vendor/.*$
Review comment:
```suggestion
exclude: ^\.github/.*$"|^airflow/_vendor/.*$
args:
- --remove
```
We could also remove them for Airflow 2.0. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
