feluelle commented on a change in pull request #5786: [AIRFLOW-5170] Fix encoding pragmas, consistent licences for python files and related pylint fixes URL: https://github.com/apache/airflow/pull/5786#discussion_r314907929
########## File path: tests/utils/log/elasticmock/__init__.py ########## @@ -48,6 +66,7 @@ def _get_elasticmock(hosts=None, *args, **kwargs): def elasticmock(f): Review comment: **f**ile or **f**unction ? That is what I meant with "being careful" with `good-names`. We defined `f` as [shorthand for file](https://github.com/apache/airflow/blob/master/pylintrc#L454), but in this case it is used probably for function. So we should change this probably to: ```suggestion def elasticmock(function): ``` (or func if this works) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
