hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1412785989
##########
airflow/www/static/js/dag/details/index.tsx:
##########
@@ -136,7 +144,11 @@ const Details = ({
const isMappedTaskSummary = isMapped && mapIndex === undefined && taskId;
const isGroup = !!children;
const isGroupOrMappedTaskSummary = isGroup || isMappedTaskSummary;
- const showLogs = !!(isTaskInstance && !isGroupOrMappedTaskSummary);
+ const isIndividualTaskInstance = !!(
+ isTaskInstance && !isGroupOrMappedTaskSummary
+ );
+ const showLogs = isIndividualTaskInstance;
+ const showXcom = isIndividualTaskInstance;
Review Comment:
I have tried to refactor this as per your suggestion in commit
[fec1b](https://github.com/apache/airflow/pull/35719/commits/fec1baedc812921bae3b621eb8dc9a9782f5817f).
I'm not too sure if this is what you intended.
I also removed the `show...` vars and use the `is...` vars for rendering
since they are just one to one. If this makes thing more confusing I can easily
revert
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
