bbovenzi commented on PR #35863:
URL: https://github.com/apache/airflow/pull/35863#issuecomment-1839046118
> Thanks @bbovenzi for the feedback. I will try to fix them in next commit.
I had few questions :
>
> 1. Would it be good for the user to click on one of the bars so that it
takes them to the task instance since its useful in cases where user finds
something odd like a task took more than usual time that they want to check
logs or know more about it? I found that there is events for echarts but I am
not sure how I can get the particular object to add the event handler.
> 2. Sometimes but not always I find the task duration bars to be different
in order than the rows in the grid though both use same data from the API. I
couldn't find an exact scenario to reproduce it. Is there any sorting involved
in grid that I should be doing in the task instance page too or something
echarts is doing.
>
> > Let's have x-axis labels still
>
> Does this mean just having x-axis to indicate that just says "run_id" like
"duration(seconds)" or the actual value of run_id beneath each bar which might
be make it little harder to read on large num_runs.
1. Yes
2. In grid_data we have a ordering variable to tell the UI to sort it by
dataIntervalStart/End or executionDate. You may need to check against it
X-Axis labels: No, just the formatted time of the datetime we are ordering
the tasks by. RunId can stay in the tooltip
I also think we could bring in some Task details to this page. Basic stuff
like the operator that comes from `/dags/{dag_id}/tasks/{task_id}` in the rest
API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
