tirkarthi commented on PR #35863:
URL: https://github.com/apache/airflow/pull/35863#issuecomment-1843348683

   
   > Let's have x-axis labels still
   
   Done. I had instance as x-axis which leads to formatting as [object object] 
in the UI. I rely on execution date as using dataIntervalEnd leads to cases 
where there is a scheduled run and manual run with same dataIntervalEnd that 
causes them to form a single bar though they are two different task instances. 
I feel execution date which is mostly referred as logical date is unique 
enough. Please share your thoughts on this and the date format.
   
   > We can make the queued gray color a little lighter. I believe I did this 
already in the gantt chart
   
   Done. Used opacity as 0.6 as done in gantt chart
   
   > Can we make sure the tooltip has an arrow so a user can be certain on 
which column they are looking at?
   
   There is hand pointer on hovering over the bar in task instance. Do you want 
the task duration and grid view in sync? I had it in the previous version to 
show it on hover which needs setting task_id and run_id query params and 
accidental hover causes browser history to be filled with values that makes 
clicking on back little difficult. Since now task duration is a separate tab 
only with task_id in query param I have changed it to on click so that when 
user is interested in filtering by task instance they can click on it to move 
to task instance detail view. Reverting to older method means hover by itself 
moves to task instance detail and hides task duration.
   
   > Let's include try number in the tooltip
   
   Done
   
   Screenshot after addressing comments : 
   
   
![image](https://github.com/apache/airflow/assets/3972343/4197ebd6-6b26-4d65-9506-94f1b6506765)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to